[master] 4f03022 Avoid sideeffects in assert

[Poul-Henning Kamp]

commit 4f03022ff35124a44cbde4f72181203575898720
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Mon Feb 13 11:11:27 2017 +0000

    Avoid sideeffects in assert
    
    Spotted by: Coverity

diff --git a/bin/varnishd/cache/cache_shmlog.c b/bin/varnishd/cache/cache_shmlog.c
index cc3345d..c9776ab 100644
--- a/bin/varnishd/cache/cache_shmlog.c
+++ b/bin/varnishd/cache/cache_shmlog.c
@@ -401,7 +401,8 @@ VSLb_bin(struct vsl_log *vsl, enum VSL_tag_e tag, ssize_t len, const void *ptr)
 	assert(VSL_END(vsl->wlp, len * 2 + 1) < vsl->wle);
 	p = VSL_DATA(vsl->wlp);
 	for (ll = 0; ll < len; ll++) {
-		assert(snprintf(p, 3, "%02x", *pp++) == 2);
+		assert(snprintf(p, 3, "%02x", *pp) == 2);
+		pp++;
 		p += 2;
 	}
 	if (suff)