[master] 138fecb A quick word on thread_pool bounds

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Tue May 16 11:19:05 CEST 2017


commit 138fecbd777c76e5b5ee0eb78cb8dd84bfd9fee7
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Tue May 16 11:16:56 2017 +0200

    A quick word on thread_pool bounds
    
    It's sometimes confusing new users, and it managed to confuse me too a
    couple months ago.

diff --git a/bin/varnishd/mgt/mgt_pool.c b/bin/varnishd/mgt/mgt_pool.c
index 95e667c..49b9b5e 100644
--- a/bin/varnishd/mgt/mgt_pool.c
+++ b/bin/varnishd/mgt/mgt_pool.c
@@ -99,7 +99,8 @@ struct parspec WRK_parspec[] = {
 		"2", "pools" },
 	{ "thread_pool_max", tweak_thread_pool_max, &mgt_param.wthread_max,
 		NULL, NULL,
-		"The maximum number of worker threads in each pool.\n"
+		"The maximum number of worker threads in each pool. The "
+		"minimum value depends on thread_pool_min.\n"
 		"\n"
 		"Do not set this higher than you have to, since excess "
 		"worker threads soak up RAM and CPU and generally just get "
@@ -108,7 +109,8 @@ struct parspec WRK_parspec[] = {
 		"5000", "threads" },
 	{ "thread_pool_min", tweak_thread_pool_min, &mgt_param.wthread_min,
 		NULL, NULL,
-		"The minimum number of worker threads in each pool.\n"
+		"The minimum number of worker threads in each pool. The "
+		"maximum value depends on thread_pool_max.\n"
 		"\n"
 		"Increasing this may help ramp up faster from low load "
 		"situations or when threads have expired.\n"



More information about the varnish-commit mailing list