[master] 75744c8 Notes after another review of restarts changes
Nils Goroll
nils.goroll at uplex.de
Wed Nov 8 07:31:06 UTC 2017
commit 75744c85a94ac2c4aaaeb10f107462f7a11656db
Author: Nils Goroll <nils.goroll at uplex.de>
Date: Wed Nov 8 08:10:02 2017 +0100
Notes after another review of restarts changes
diff --git a/bin/varnishd/cache/cache_req.c b/bin/varnishd/cache/cache_req.c
index 2f1014f..6ee3050 100644
--- a/bin/varnishd/cache/cache_req.c
+++ b/bin/varnishd/cache/cache_req.c
@@ -175,6 +175,7 @@ Req_Release(struct req *req)
}
/*----------------------------------------------------------------------
+ * TODO: remove code duplication with cnt_recv_prep
*/
void
diff --git a/bin/varnishd/cache/cache_req_fsm.c b/bin/varnishd/cache/cache_req_fsm.c
index cbf3576..c593e93 100644
--- a/bin/varnishd/cache/cache_req_fsm.c
+++ b/bin/varnishd/cache/cache_req_fsm.c
@@ -741,6 +741,10 @@ cnt_restart(struct worker *wrk, struct req *req)
/*
* prepare the request for vcl_recv, either initially or after a reset
* e.g. due to vcl switching
+ *
+ * TODO
+ * - make restarts == 0 bit re-usable for rollback
+ * - remove duplicatation with Req_Cleanup()
*/
static void
More information about the varnish-commit
mailing list