[master] 19080c0 Hold the sess mutex when evaluating r2->cond

[Dag Haavi Finstad]

commit 19080c05ebf65a7245f2aded0bbb5e5a95d07201
Author: Dag Haavi Finstad <daghf at varnish-software.com>
Date:   Tue Oct 10 11:46:19 2017 +0200

    Hold the sess mutex when evaluating r2->cond
    
    The extra locking prevents the race where a request thread is setting
    r2->cond = NULL and the session thread is testing r2->cond != NULL.
    
    Fixes: #2434

diff --git a/bin/varnishd/http2/cache_http2_session.c b/bin/varnishd/http2/cache_http2_session.c
index 63f6f95..b7e1783 100644
--- a/bin/varnishd/http2/cache_http2_session.c
+++ b/bin/varnishd/http2/cache_http2_session.c
@@ -320,6 +320,7 @@ h2_new_session(struct worker *wrk, void *arg)
 
 	/* Delete all idle streams */
 	VSLb(h2->vsl, SLT_Debug, "H2 CLEANUP %s", h2->error->name);
+	Lck_Lock(&h2->sess->mtx);
 	VTAILQ_FOREACH(r2, &h2->streams, list) {
 		if (r2->error == 0)
 			r2->error = h2->error;
@@ -327,6 +328,7 @@ h2_new_session(struct worker *wrk, void *arg)
 			AZ(pthread_cond_signal(r2->cond));
 	}
 	AZ(pthread_cond_broadcast(h2->cond));
+	Lck_Unlock(&h2->sess->mtx);
 	while (1) {
 		again = 0;
 		VTAILQ_FOREACH_SAFE(r2, &h2->streams, list, r22) {