[6.0] 17eb66323 Silence a Coverity non-defect

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Thu Aug 16 08:53:01 UTC 2018


commit 17eb66323a702a85b56a59786cb1039e1491e1f2
Author: Dag Haavi Finstad <daghf at varnish-software.com>
Date:   Thu May 24 10:06:34 2018 +0200

    Silence a Coverity non-defect

diff --git a/bin/varnishd/cache/cache_panic.c b/bin/varnishd/cache/cache_panic.c
index 0666c89e7..cf22c0ea7 100644
--- a/bin/varnishd/cache/cache_panic.c
+++ b/bin/varnishd/cache/cache_panic.c
@@ -401,6 +401,7 @@ pan_busyobj(struct vsb *vsb, const struct busyobj *bo)
 	VSB_indent(vsb, 2);
 	PAN_CheckMagic(vsb, bo, BUSYOBJ_MAGIC);
 	pan_ws(vsb, bo->ws);
+	AN(bo->vfc);
 	VSB_printf(vsb, "retries = %d, ", bo->retries);
 	VSB_printf(vsb, "failed = %d, ", bo->vfc->failed);
 	VSB_printf(vsb, "flags = {");
@@ -415,8 +416,7 @@ pan_busyobj(struct vsb *vsb, const struct busyobj *bo)
 	if (VALID_OBJ(bo->htc, HTTP_CONN_MAGIC))
 		pan_htc(vsb, bo->htc);
 
-	if (bo->vfc)
-		pan_vfp(vsb, bo->vfc);
+	pan_vfp(vsb, bo->vfc);
 
 	VDI_Panic(bo->director_req, vsb, "director_req");
 	if (bo->director_resp == bo->director_req)


More information about the varnish-commit mailing list