[master] 5b6a4e560 travis: Our svg bits require graphviz

Dridi Boukelmoune dridi at varni.sh
Thu Dec 6 09:54:42 UTC 2018


On Thu, Dec 6, 2018 at 10:48 AM Dag Haavi Finstad
<daghf at varnish-software.com> wrote:
>
> Something else is probably wrong, then?
>
> I did this because I noticed Nils' PR #2859 is currently failing in travis because of what looks to be a missing graphviz dependency.
> https://github.com/varnishcache/varnish-cache/pull/2859
> https://travis-ci.org/varnishcache/varnish-cache/jobs/463897300
>
> I'll revert.

Nils is very much aware of this (he recently made modifications to the
FSM diagrams outside of this PR) and most likely didn't update the
SVGs on purpose.

> I Intentionally did not include the generated SVGs in this PR to not add changes without any semantic value.

I read he omitted them to avoid SVG noise in the diff for reviewers.

Dridi


More information about the varnish-commit mailing list