[master] 79e91c0 mark a tbd: For background fetches from vcl_hit, should we go to vcl_miss ?

[Nils Goroll]

commit 79e91c03e2849ec5bc9b744a766507260c6801b5
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Sat Feb 24 10:59:09 2018 +0100

    mark a tbd: For background fetches from vcl_hit, should we go to vcl_miss ?
    
    There might be code in vcl_miss changing the request which we don't
    run for bgfetches, which could lead to unexpected behaviour.
    
    On the other hand, what purpose does vcl_miss serve? Is there anything
    we can do in vcl_miss which we can't do in vcl_backend_fetch?

diff --git a/bin/varnishd/cache/cache_req_fsm.c b/bin/varnishd/cache/cache_req_fsm.c
index 56bf79e..385e899 100644
--- a/bin/varnishd/cache/cache_req_fsm.c
+++ b/bin/varnishd/cache/cache_req_fsm.c
@@ -529,6 +529,7 @@ cnt_lookup(struct worker *wrk, struct req *req)
 		if (busy != NULL) {
 			AZ(oc->flags & OC_F_PASS);
 			CHECK_OBJ_NOTNULL(busy->boc, BOC_MAGIC);
+			// XXX: shouldn't we go to miss?
 			VBF_Fetch(wrk, req, busy, oc, VBF_BACKGROUND);
 		} else {
 			(void)VRB_Ignore(req);// XXX: handle err