[master] ca1eca7 Use strong VRND for silo unique number

Poul-Henning Kamp phk at FreeBSD.org
Wed Jun 6 13:44:15 UTC 2018


commit ca1eca7838d5d17bb9e301944e40b4bf685e5738
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Wed Jun 6 13:11:08 2018 +0000

    Use strong VRND for silo unique number

diff --git a/bin/varnishd/storage/storage_persistent_subr.c b/bin/varnishd/storage/storage_persistent_subr.c
index 05ce659..9f8d202 100644
--- a/bin/varnishd/storage/storage_persistent_subr.c
+++ b/bin/varnishd/storage/storage_persistent_subr.c
@@ -45,6 +45,7 @@
 
 #include "storage/storage.h"
 
+#include "vrnd.h"
 #include "vsha256.h"
 
 #include "storage/storage_persistent.h"
@@ -280,7 +281,7 @@ smp_newsilo(struct smp_sc *sc)
 	assert(strlen(SMP_IDENT_STRING) < sizeof si->ident);
 
 	/* Choose a new random number */
-	sc->unique = random();
+	AZ(VRND_RandomCrypto(&sc->unique, sizeof sc->unique));
 
 	smp_reset_sign(&sc->idn);
 	si = sc->ident;


More information about the varnish-commit mailing list