[master] 62c00fd More work to slim down the cache.h API
Poul-Henning Kamp
phk at phk.freebsd.dk
Thu Mar 8 09:08:42 UTC 2018
--------
In message <CABoVN9BPG3G8Hp2cry-oa7GkwXOn_ywc=Q00tnE8UMBCPE=cPA at mail.gmail.com>
, Dridi Boukelmoune writes:
>> -/*
>> - * XXX should cache.h refer to cache_param if common_param.h
>> - * is not in $DIST ?
>> - */
>> -#define FEATURE(x) COM_FEATURE(cache_param->feature_bits, x)
>> -#define DO_DEBUG(x) COM_DO_DEBUG(cache_param->debug_bits, x)
>> -
>> #define DSL(debug_bit, id, ...) \
>> do { \
>> if (DO_DEBUG(debug_bit)) \
>
>DO_DEBUG is removed from the API but used right below in DSL(). Also
>should we really hide those flags? There's at least vtc_mode that
>could be really useful to VMOD authors.
We don't expose the layout of the param structure at the cache.h
API level, so these macros are useless.
I will move DSL as well.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
More information about the varnish-commit
mailing list