[master] c3bd169 Silence a Coverity non-defect

Dag Haavi Finstad daghf at varnish-software.com
Thu May 24 09:07:50 UTC 2018


On Thu, May 24, 2018 at 10:22 AM, Dridi Boukelmoune <dridi at varni.sh> wrote:

> > --- a/bin/varnishd/cache/cache_panic.c
> > +++ b/bin/varnishd/cache/cache_panic.c
> > @@ -401,6 +401,7 @@ pan_busyobj(struct vsb *vsb, const struct busyobj
> *bo)
> >         VSB_indent(vsb, 2);
> >         PAN_CheckMagic(vsb, bo, BUSYOBJ_MAGIC);
> >         pan_ws(vsb, bo->ws);
> > +       AN(bo->vfc);
>
> Is it safe to put an assert here? Shouldn't we guard accesses to
> bo->vfc if Nils thought it could be NULL?
>
>
bo->vfc has the same lifetime as the bo itself, so that should be OK.

-- 
Dag Haavi Finstad
Software Developer | Varnish Software
Mobile: +47 476 64 134
We Make Websites Fly!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20180524/72a6866e/attachment.html>


More information about the varnish-commit mailing list