[master] 5c60aaa9a remove a useless volatile

Nils Goroll nils.goroll at uplex.de
Thu Oct 18 17:08:10 UTC 2018


commit 5c60aaa9af86d4d3fa456057a26f2b92e5de7cf1
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Thu Oct 18 17:59:05 2018 +0200

    remove a useless volatile
    
    ... introduced with 8c113ff64b78554f6219f14774fed418c466318c
    
    Here it seems the intention was to make sure that the access to the
    parameter happens uncached, but even then it would not have helped.

diff --git a/bin/varnishd/cache/cache_ban_lurker.c b/bin/varnishd/cache/cache_ban_lurker.c
index febc57ff3..569f7e06e 100644
--- a/bin/varnishd/cache/cache_ban_lurker.c
+++ b/bin/varnishd/cache/cache_ban_lurker.c
@@ -408,7 +408,7 @@ void * v_matchproto_(bgthread_t)
 ban_lurker(struct worker *wrk, void *priv)
 {
 	struct vsl_log vsl;
-	volatile vtim_real d;
+	vtim_real d;
 	vtim_dur dt;
 	unsigned gen = ban_generation + 1;
 


More information about the varnish-commit mailing list