[6.0] 29f5ad61d side effect of staring at code not worth a ticket
Dridi Boukelmoune
dridi.boukelmoune at gmail.com
Wed Oct 31 13:08:12 UTC 2018
commit 29f5ad61db0517066d8a946ac1aceaf083c2887f
Author: Nils Goroll <nils.goroll at uplex.de>
Date: Mon Sep 3 18:11:42 2018 +0200
side effect of staring at code not worth a ticket
diff --git a/bin/varnishd/cache/cache_hash.c b/bin/varnishd/cache/cache_hash.c
index c3b652bbe..1b63d906d 100644
--- a/bin/varnishd/cache/cache_hash.c
+++ b/bin/varnishd/cache/cache_hash.c
@@ -407,6 +407,8 @@ HSH_Lookup(struct req *req, struct objcore **ocp, struct objcore **bocp,
continue;
if (oc->boc != NULL && oc->boc->state < BOS_STREAM) {
+ // XXX does it make sense to have the CHECK_OBJ
+ // if we access boc->state before it?
CHECK_OBJ_ORNULL(oc->boc, BOC_MAGIC);
if (req->hash_ignore_busy)
More information about the varnish-commit
mailing list