[6.0] adc8a14e5 remove markers about an issue now solved
Dridi Boukelmoune
dridi.boukelmoune at gmail.com
Wed Oct 31 13:08:23 UTC 2018
commit adc8a14e5d2c08cc7f0640a506e75228fa2444d8
Author: Nils Goroll <nils.goroll at uplex.de>
Date: Wed Sep 26 08:12:38 2018 +0200
remove markers about an issue now solved
diff --git a/bin/varnishd/cache/cache_ban.c b/bin/varnishd/cache/cache_ban.c
index 5e8712503..6ec3577d2 100644
--- a/bin/varnishd/cache/cache_ban.c
+++ b/bin/varnishd/cache/cache_ban.c
@@ -168,10 +168,6 @@ ban_mark_completed(struct ban *b)
vbe32enc(b->spec + BANS_LENGTH, BANS_HEAD_LEN);
VSC_C_main->bans_completed++;
bans_persisted_fragmentation += ln - ban_len(b->spec);
- /*
- * XXX absolute update of gauges - may be inaccurate for
- * Pool_Sumstat race
- */
VSC_C_main->bans_persisted_fragmentation =
bans_persisted_fragmentation;
}
@@ -319,10 +315,6 @@ ban_export(void)
assert(VSB_len(vsb) == ln);
STV_BanExport((const uint8_t *)VSB_data(vsb), VSB_len(vsb));
VSB_destroy(&vsb);
- /*
- * XXX absolute update of gauges - may be inaccurate for Pool_Sumstat
- * race
- */
VSC_C_main->bans_persisted_bytes =
bans_persisted_bytes = ln;
VSC_C_main->bans_persisted_fragmentation =
@@ -406,10 +398,6 @@ ban_reload(const uint8_t *ban, unsigned len)
else
VTAILQ_INSERT_BEFORE(b, b2, list);
bans_persisted_bytes += len;
- /*
- * XXX absolute update of gauges - may be inaccurate for Pool_Sumstat
- * race
- */
VSC_C_main->bans_persisted_bytes = bans_persisted_bytes;
/* Hunt down older duplicates */
diff --git a/bin/varnishd/cache/cache_ban_lurker.c b/bin/varnishd/cache/cache_ban_lurker.c
index 0680941ae..defe55d91 100644
--- a/bin/varnishd/cache/cache_ban_lurker.c
+++ b/bin/varnishd/cache/cache_ban_lurker.c
@@ -89,10 +89,6 @@ ban_cleantail(const struct ban *victim)
VTAILQ_INSERT_TAIL(&freelist, b, list);
bans_persisted_fragmentation +=
ban_len(b->spec);
- /*
- * XXX absolute update of gauges - may be inaccurate for
- * Pool_Sumstat race
- */
VSC_C_main->bans_persisted_fragmentation =
bans_persisted_fragmentation;
ban_info_drop(b->spec, ban_len(b->spec));
More information about the varnish-commit
mailing list