[master] eedfa1e4d Revert "no need to sum stats which we don't use"

Nils Goroll nils.goroll at uplex.de
Thu Sep 27 18:34:06 UTC 2018


commit eedfa1e4d7395b67cc17ebfece2ebde6333a515a
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Thu Sep 27 20:32:25 2018 +0200

    Revert "no need to sum stats which we don't use"
    
    my apologies: as long as we pass around a struct wrk, some other
    function could use the wrk->stats - in other words, the fact that
    the ban stats are decoupled from the wrk stats does not make the
    latter any less relevant.
    
    This reverts commit 527f1bd0b74e758c6f8b8ae189b293151e61cd15.

diff --git a/bin/varnishd/cache/cache_ban_lurker.c b/bin/varnishd/cache/cache_ban_lurker.c
index a56119c62..1729e04a9 100644
--- a/bin/varnishd/cache/cache_ban_lurker.c
+++ b/bin/varnishd/cache/cache_ban_lurker.c
@@ -422,6 +422,7 @@ ban_lurker(struct worker *wrk, void *priv)
 		d += VTIM_real();
 		Lck_Lock(&ban_mtx);
 		if (gen == ban_generation) {
+			Pool_Sumstat(wrk);
 			(void)Lck_CondWait(&ban_lurker_cond, &ban_mtx, d);
 			ban_batch = 0;
 		}


More information about the varnish-commit mailing list