[master] 458306fa8 the XXX marks the spot

Nils Goroll nils.goroll at uplex.de
Sun Apr 7 15:59:06 UTC 2019


commit 458306fa8ea4391b4567e52a5b869267b0f76ffc
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Sun Apr 7 15:30:17 2019 +0200

    the XXX marks the spot
    
    ... where we would need error handling

diff --git a/bin/varnishd/http2/cache_http2_hpack.c b/bin/varnishd/http2/cache_http2_hpack.c
index 0524f3e32..5a12f8890 100644
--- a/bin/varnishd/http2/cache_http2_hpack.c
+++ b/bin/varnishd/http2/cache_http2_hpack.c
@@ -176,8 +176,11 @@ h2h_decode_init(const struct h2_sess *h2)
 	INIT_OBJ(d, H2H_DECODE_MAGIC);
 	VHD_Init(d->vhd);
 	d->out_l = WS_Reserve(h2->new_req->http->ws, 0);
-	assert(d->out_l > 0);	/* Can't do any work without any buffer
-				   space. Require non-zero size. */
+	/*
+	 * Can't do any work without any buffer
+	 * space. Require non-zero size.
+	 */
+	XXXAN(d->out_l);
 	d->out = h2->new_req->http->ws->f;
 	d->reset = d->out;
 }


More information about the varnish-commit mailing list