[master] 3ce0d377e ws functions are not part of vrt, so mark them

Nils Goroll nils.goroll at uplex.de
Wed Apr 10 06:59:53 UTC 2019


I totally agree. Anything which basically all vmods need should be in vrt.h

@phk ok to move WS_* to vrt.h ?

Nils

On 09/04/2019 10:34, Dridi Boukelmoune wrote:
> On Mon, Apr 8, 2019 at 4:59 PM Nils Goroll <nils.goroll at uplex.de> wrote:
>>
>> On 08/04/2019 15:51, Dridi Boukelmoune wrote:
>>> I thought cache.h was part of VRT and cache_varnishd.h was strict ABI.
>>
>> um yes. And no.
>>
>> We might have a bit of confusion wrt VRT (pun intended) in the vmod $ABI sense
>> (for which cache.h is forbidden) and the fact that is, after all, still part of
>> our ABI.
> 
> I thought the whole cache_varnishd.h split was done to allow cache.h in VRT.
> 
> If we want to make cache.h $ABI strict, we should move the relevant
> WS_* prototypes to vrt.h at least to not make 90% of $ABI vrt modules
> turn strict. We can keep struct ws opaque, but those are critical for
> VMOD authors (it also means no more CHECK_OBJ_NOTNULL but AN
> instead on ctx->ws).
> 
> Having to always rebuild a VMOD when Varnish updates because you make
> workspace allocations bring a poor out-of-tree experience. That forces
> everyone to use a priv_task instead for simple allocations, and that priv_task
> may need to keep track of multiple allocations too for each VMOD.
> 
> Too much complexity for $ABI strict makes it unusable.
> 
> Dridi
> 


-- 

** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

tel +49 40 28805731
mob +49 170 2723133
fax +49 40 42949753

xmpp://slink@jabber.int.uplex.de/

http://uplex.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20190410/2507e7d4/attachment.bin>


More information about the varnish-commit mailing list