[master] 3ce0d377e ws functions are not part of vrt, so mark them

Poul-Henning Kamp phk at phk.freebsd.dk
Wed Apr 10 08:05:11 UTC 2019


--------
In message <356c6c8a-8350-956d-e5f0-8473d59b6843 at uplex.de>, Nils Goroll writes:

>@phk ok to move WS_* to vrt.h ?

You are not going to get a fast answer to this one, and I want to
use this as an example of why sometimes things take time around here.

My initial leaning is: Hell NO!

We're not doing nearly as good a job as I wish of keeping VRT
"isolated" from varnishd internals, but that doesn't mean I'm going
to throw it all overboard.

If we put WS_* into vrt.h we are essentially stuck with it forever.

So far I have very deliberately kept WS out of vrt.h because I want
us to retain the ability to redo the basic WS concept if the static
allocation becomes unworkable down the road, and it is starting to
look a bit geriatric these days.

The alternative to just making WS be VRT, is to add some VRT memory
allocation functions which wrap WS, and I would be much more receptive to that.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


More information about the varnish-commit mailing list