[master] a4d79267e Remove XXXes which have been addressed

Nils Goroll nils.goroll at uplex.de
Mon Apr 15 14:11:07 UTC 2019


commit a4d79267eca936654d515eeecf97f5bd98b26a58
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Mon Apr 15 15:44:47 2019 +0200

    Remove XXXes which have been addressed

diff --git a/bin/varnishd/cache/cache_ban_build.c b/bin/varnishd/cache/cache_ban_build.c
index 660bdabc0..228d18c4b 100644
--- a/bin/varnishd/cache/cache_ban_build.c
+++ b/bin/varnishd/cache/cache_ban_build.c
@@ -353,10 +353,6 @@ BAN_Commit(struct ban_proto *bp)
 	VSC_C_main->bans++;
 	VSC_C_main->bans_added++;
 	bans_persisted_bytes += ln;
-	/*
-	 * XXX absolute update of gauges - may be inaccurate for Pool_Sumstat
-	 * race
-	 */
 	VSC_C_main->bans_persisted_bytes = bans_persisted_bytes;
 
 	if (b->flags & BANS_FLAG_OBJ)
diff --git a/bin/varnishd/cache/cache_director.c b/bin/varnishd/cache/cache_director.c
index 423eb0550..0c1098da9 100644
--- a/bin/varnishd/cache/cache_director.c
+++ b/bin/varnishd/cache/cache_director.c
@@ -364,7 +364,6 @@ do_list_json(struct cli *cli, struct director *d, void *priv)
 
 	VCLI_Out(cli, "%s", la->jsep);
 	la->jsep = ",\n";
-	// XXX admin health "probe" for the no-probe case is confusing
 	VCLI_JSON_str(cli, d->vdir->cli_name);
 	VCLI_Out(cli, ": {\n");
 	VSB_indent(cli->sb, 2);


More information about the varnish-commit mailing list