[master] a90a099dd mv coccinelle/ tools/

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Tue Apr 16 08:08:07 UTC 2019


commit a90a099dd9d476135ab0da97f498c607b18ef3c5
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Tue Apr 16 09:19:21 2019 +0200

    mv coccinelle/ tools/
    
    I also decided to lowercase semantic patch file names, and to not
    mislead people about the WS_Reserve change being a vmod-only thing.

diff --git a/coccinelle/README.rst b/coccinelle/README.rst
deleted file mode 100644
index f279cb563..000000000
--- a/coccinelle/README.rst
+++ /dev/null
@@ -1,10 +0,0 @@
-This directory contains `coccinelle`_ patches to facilitate code
-maintenance.
-
-Each patch should, in a comment section, explain its purpose.
-
-Unless noted otherwise, all patches should work when invoked as::
-
-	spatch --dir . --in-place --sp-file $COCCI
-
-.. _coccinelle: http://coccinelle.lip6.fr/
diff --git a/doc/changes.rst b/doc/changes.rst
index 8f8e52139..b3923dce8 100644
--- a/doc/changes.rst
+++ b/doc/changes.rst
@@ -63,8 +63,8 @@ C APIs (for vmod and utility authors)
     It will only leave the workspace reserved if the reservation
     request could be fulfilled.
 
-  We provide a script to automate this change in the ``coccinelle``
-  subdirectory of the source tree.
+  We provide a script to help automate this change in the
+  ``tools/coccinelle`` subdirectory of the source tree.
 
 ================================
 Varnish Cache 6.2.0 (2019-03-15)
diff --git a/tools/coccinelle/README.rst b/tools/coccinelle/README.rst
new file mode 100644
index 000000000..ff01e80bf
--- /dev/null
+++ b/tools/coccinelle/README.rst
@@ -0,0 +1,11 @@
+This directory contains `coccinelle`_ semantic patches to facilitate code
+maintenance.
+
+Each patch should, in a comment section, explain its purpose. They may be fit
+for both the in-tree code style or out-of-tree VMOD and VUT development.
+
+Unless noted otherwise, all patches should work when invoked as::
+
+	spatch --dir . --in-place --sp-file $COCCI
+
+.. _coccinelle: http://coccinelle.lip6.fr/
diff --git a/coccinelle/vmod/WS_Reserve.cocci b/tools/coccinelle/ws_reserve.cocci
similarity index 87%
rename from coccinelle/vmod/WS_Reserve.cocci
rename to tools/coccinelle/ws_reserve.cocci
index f40a49dbb..14e6cf846 100644
--- a/coccinelle/vmod/WS_Reserve.cocci
+++ b/tools/coccinelle/ws_reserve.cocci
@@ -1,5 +1,5 @@
 /*
- * patch to change code with respect to #2969: Replacement of
+ * Patch to change code with respect to #2969: Replacement of
  * WS_Reserve(ws, sz) by WS_ReserveAll(ws) / WS_ReserveSize(ws, sz)
  *
  * NOTE this patch does not check/fix error handling:


More information about the varnish-commit mailing list