[master] 462e9568d Restore suggestion burried in the commit log

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Tue Apr 16 08:56:06 UTC 2019


commit 462e9568d79e1f3a7d8837d39e0bef4c7c69744c
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Tue Apr 16 10:54:34 2019 +0200

    Restore suggestion burried in the commit log

diff --git a/tools/coccinelle/closefd.cocci b/tools/coccinelle/closefd.cocci
index f1f75a33a..4afbcef9e 100644
--- a/tools/coccinelle/closefd.cocci
+++ b/tools/coccinelle/closefd.cocci
@@ -5,6 +5,11 @@
  * holding the file descriptor has a const qualifier. It also make sures that
  * fd looks like a valid file descriptor before even calling close().
  *
+ * It might be worth revisiting regularly cases that don't apply to this
+ * patch:
+ *
+ *     git grep '(void)close'
+ *
  * The second part of the patch undoes the change when fd is a constant such
  * as STDIN_FILENO where it becomes nonsensical.
  */


More information about the varnish-commit mailing list