[master] 1bef464e0 Fix comparison is always true

Federico G. Schwindt fgsch at lodoss.net
Sat Apr 20 11:24:09 UTC 2019


commit 1bef464e04f94f58c7ec2abfd24d1e4dbb438c49
Author: Federico G. Schwindt <fgsch at lodoss.net>
Date:   Sat Apr 20 10:42:54 2019 +0100

    Fix comparison is always true
    
    Via lgtm.

diff --git a/lib/libvmod_debug/vmod_debug.c b/lib/libvmod_debug/vmod_debug.c
index 7832f4ffb..51ba7dd03 100644
--- a/lib/libvmod_debug/vmod_debug.c
+++ b/lib/libvmod_debug/vmod_debug.c
@@ -133,7 +133,7 @@ xyzzy_rot13_bytes(struct req *req, enum vdp_action act, void **priv,
 			i = -1;
 		}
 	}
-	if (j > 0 && i >= 0)
+	if (i >= 0)
 		retval = VDP_bytes(req, VDP_FLUSH, q, i + 1);
 	return (retval);
 }


More information about the varnish-commit mailing list