[master] fa3e14197 setting thread_pool_timeout is useless because vtc_mode overrides

Nils Goroll nils.goroll at uplex.de
Tue Apr 23 14:54:08 UTC 2019


commit fa3e141975ee5c26735c150ce07c5575ae746578
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Tue Apr 23 16:01:04 2019 +0200

    setting thread_pool_timeout is useless because vtc_mode overrides
    
    the herder delay to .5 seconds anyway

diff --git a/bin/varnishtest/tests/r01490.vtc b/bin/varnishtest/tests/r01490.vtc
index 88c2550aa..7ca0b23e2 100644
--- a/bin/varnishtest/tests/r01490.vtc
+++ b/bin/varnishtest/tests/r01490.vtc
@@ -9,7 +9,6 @@ varnish v1 \
 	-arg "-p thread_pool_min=2" \
 	-arg "-p thread_pool_max=3" \
 	-arg "-p thread_pools=1" \
-	-arg "-p thread_pool_timeout=10" \
 	-vcl+backend {}
 varnish v1 -start
 
@@ -24,16 +23,16 @@ logexpect l1 -v v1 -g raw {
 
 varnish v1 -cliok "param.set thread_pool_min 3"
 
-# Have to wait longer than thread_pool_timeout
-delay 11
+# thread_pool_timeout overridden by vtc_mode with delay=0.5
+delay 1
 
 varnish v1 -expect threads == 3
 
 varnish v1 -cliok "param.set thread_pool_min 2"
 varnish v1 -cliok "param.set thread_pool_max 2"
 
-# Have to wait longer than thread_pool_timeout
-delay 11
+# thread_pool_timeout overridden by vtc_mode with delay=0.5
+delay 1
 
 varnish v1 -expect threads == 2
 


More information about the varnish-commit mailing list