[master] 654f0b5f4 Clear the v1l after resetting the workspace

Nils Goroll nils.goroll at uplex.de
Wed Apr 24 11:41:08 UTC 2019


commit 654f0b5f493f50b016c316a8572a29a457aa3eb5
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Tue Apr 16 15:16:35 2019 +0200

    Clear the v1l after resetting the workspace

diff --git a/bin/varnishd/http1/cache_http1_line.c b/bin/varnishd/http1/cache_http1_line.c
index 8d03d9b4f..6a471b043 100644
--- a/bin/varnishd/http1/cache_http1_line.c
+++ b/bin/varnishd/http1/cache_http1_line.c
@@ -138,6 +138,7 @@ V1L_Close(struct worker *wrk, uint64_t *cnt)
 	if (v1l->ws->r)
 		WS_Release(v1l->ws, 0);
 	WS_Reset(v1l->ws, v1l->res);
+	ZERO_OBJ(v1l, sizeof *v1l);
 	return (u);
 }
 
@@ -278,7 +279,7 @@ V1L_Chunked(const struct worker *wrk)
 	assert(v1l->ciov == v1l->siov);
 	assert(v1l->siov >= 3);
 	/*
-	 * If there are not space for chunked header, a chunk of data and
+	 * If there is no space for chunked header, a chunk of data and
 	 * a chunk tail, we might as well flush right away.
 	 */
 	if (v1l->niov + 3 >= v1l->siov)


More information about the varnish-commit mailing list