[master] 09785c4ee the current vtc -rcvbuf implementation does not work on SunOS

Nils Goroll nils.goroll at uplex.de
Wed Apr 24 12:59:07 UTC 2019


commit 09785c4ee0331a0f2111b1b501e5c2657cf39fff
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Wed Apr 24 14:56:09 2019 +0200

    the current vtc -rcvbuf implementation does not work on SunOS
    
    Ref #2980

diff --git a/bin/varnishtest/tests/s00010.vtc b/bin/varnishtest/tests/s00010.vtc
index c641db519..d3ce9473e 100644
--- a/bin/varnishtest/tests/s00010.vtc
+++ b/bin/varnishtest/tests/s00010.vtc
@@ -1,5 +1,8 @@
 varnishtest "client h1 send timeouts"
 
+# XXX See https://github.com/varnishcache/varnish-cache/pull/2980#issuecomment-486214661
+feature cmd {test $(uname) != "SunOS"}
+
 server s1 {
 	rxreq
 	txresp -bodylen 100000
diff --git a/bin/varnishtest/vtc_http.c b/bin/varnishtest/vtc_http.c
index 99b46eaf2..041690caa 100644
--- a/bin/varnishtest/vtc_http.c
+++ b/bin/varnishtest/vtc_http.c
@@ -1918,6 +1918,8 @@ http_process(struct vtclog *vl, const char *spec, int sock, int *sfd,
 	hp->timeout = vtc_maxdur * 1000 / 2;
 
 	if (rcvbuf) {
+		// XXX setsockopt() too late on SunOS
+		// https://github.com/varnishcache/varnish-cache/pull/2980#issuecomment-486214661
 		hp->rcvbuf = rcvbuf;
 
 		oldbuf = 0;


More information about the varnish-commit mailing list