[master] 462eab253 Remove a racy assert

Martin Blix Grydeland martin at varnish-software.com
Fri Apr 26 11:16:08 UTC 2019


commit 462eab25381ccfd914be4b406e46d0441257f06f
Author: Martin Blix Grydeland <martin at varnish-software.com>
Date:   Fri Apr 26 13:13:48 2019 +0200

    Remove a racy assert
    
    With the recent changes where HSH_Unbusy/HSH_Fail is called after
    ObjSetState, this assert becomes racy. Remove the assert.

diff --git a/bin/varnishd/cache/cache_fetch.c b/bin/varnishd/cache/cache_fetch.c
index 63738e1fe..0dc8c3697 100644
--- a/bin/varnishd/cache/cache_fetch.c
+++ b/bin/varnishd/cache/cache_fetch.c
@@ -980,9 +980,6 @@ VBF_Fetch(struct worker *wrk, struct req *req, struct objcore *oc,
 			(void)VRB_Ignore(req);
 		} else {
 			ObjWaitState(oc, BOS_STREAM);
-			if (oc->boc->state == BOS_FAILED) {
-				AN((oc->flags & OC_F_FAILED));
-			}
 		}
 	}
 	AZ(bo);


More information about the varnish-commit mailing list