[6.0] 78886a10a Revert "Make FlexeLint a little bit happier"

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Wed Feb 6 08:40:12 UTC 2019


commit 78886a10ab88ef7e5d62168fb000d6112ffa26f9
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Wed Nov 14 12:43:41 2018 +0100

    Revert "Make FlexeLint a little bit happier"
    
    The fact that a boolean argument is present does not imply
    that it's true.
    
    This reverts commit 57cd74cf51b63a54df68600a573eb0e20e2a6c7a.
    
    I promise to look after this once I got my Flexelint config back,
    which, unfortunately, I lost during a reinstall. Yes, I do have
    a backup, but cannot access it easily at the moment.

diff --git a/lib/libvmod_debug/vmod_debug_obj.c b/lib/libvmod_debug/vmod_debug_obj.c
index 3ecf33d0c..9038bcb81 100644
--- a/lib/libvmod_debug/vmod_debug_obj.c
+++ b/lib/libvmod_debug/vmod_debug_obj.c
@@ -183,9 +183,6 @@ xyzzy_obj_opt__init(VRT_CTX,
 	if (args->valid_s)
 		AN(args->s);
 
-	if (args->valid_b)
-		AN(args->b);
-
 	AN(op);
 	AZ(*op);
 	ALLOC_OBJ(o, VMOD_DEBUG_OBJ_OPT_MAGIC);


More information about the varnish-commit mailing list