[master] 32d2c8657 Park issue #2332 in a XXX comment, pending API renovation.

Poul-Henning Kamp phk at FreeBSD.org
Wed Feb 6 08:52:08 UTC 2019


commit 32d2c86570cbf3bcb8a14c8c12b88d853e54e8cb
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Wed Feb 6 08:51:21 2019 +0000

    Park issue #2332 in a XXX comment, pending API renovation.

diff --git a/bin/varnishd/http1/cache_http1_fetch.c b/bin/varnishd/http1/cache_http1_fetch.c
index c5ccee3b0..f1b0ac3cb 100644
--- a/bin/varnishd/http1/cache_http1_fetch.c
+++ b/bin/varnishd/http1/cache_http1_fetch.c
@@ -111,6 +111,15 @@ V1F_SendReq(struct worker *wrk, struct busyobj *bo, uint64_t *ctr_hdrbytes,
 		i = VRB_Iterate(bo->req, vbf_iter_req_body, bo);
 
 		if (bo->req->req_body_status == REQ_BODY_FAIL) {
+			/*
+			 * XXX: (#2332) We should test to see if the backend
+			 * XXX: sent us some headers explaining why.
+			 * XXX: This is hard because of the mistaken API split
+			 * XXX: between cache_backend.c and V1F, and therefore
+			 * XXX: Parked in this comment, pending renovation of
+			 * XXX: the VDI/backend-protocol API to allow non-H1
+			 * XXX: backends.
+			 */
 			assert(i < 0);
 			VSLb(bo->vsl, SLT_FetchError,
 			    "req.body read error: %d (%s)",


More information about the varnish-commit mailing list