[master] 4cf4bbefe Shorten compiler flags when developing.
Lasse Karstensen
lasse.karstensen at gmail.com
Tue Feb 26 15:03:07 UTC 2019
commit 4cf4bbefe0ad1801852e116c46f7059c6c30dc48
Author: Lasse Karstensen <lasse.karstensen at gmail.com>
Date: Tue Feb 26 10:34:03 2019 +0100
Shorten compiler flags when developing.
This commit attempts to make it easier to read build output, and
hopefully makes configure.ac easier as well.
-Wall has already been added around line 645, no need to add it twice.
On GCC -Wreturn-type is a part of -Wall, which we enable elsewhere.
https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
On Clang -Wreturn-type is enabled by default:
https://clang.llvm.org/docs/DiagnosticsReference.html#wreturn-type
Same with -Wswitch as -Wreturn-type, so that can be removed as well.
Finally, use spaces instead of tabs to make cc output shorter and more
readable.
diff --git a/configure.ac b/configure.ac
index 804da7992..985dd64d1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -671,24 +671,20 @@ AX_CHECK_COMPILE_FLAG([-Werror=unused-result],
# This corresponds to FreeBSD's WARNS level 6
DEVELOPER_CFLAGS=" \
- -Werror \
- -Wall \
- -Wno-format-y2k \
- -W \
- -Wstrict-prototypes \
- -Wmissing-prototypes \
- -Wpointer-arith \
- -Wreturn-type \
- -Wcast-qual \
- -Wwrite-strings \
- -Wswitch \
- -Wshadow \
- -Wunused-parameter \
- -Wcast-align \
- -Wchar-subscripts \
- -Wnested-externs \
- -Wextra \
- -Wno-sign-compare \
+ -Werror \
+ -Wno-format-y2k \
+ -Wstrict-prototypes \
+ -Wmissing-prototypes \
+ -Wpointer-arith \
+ -Wcast-qual \
+ -Wwrite-strings \
+ -Wshadow \
+ -Wunused-parameter \
+ -Wcast-align \
+ -Wchar-subscripts \
+ -Wnested-externs \
+ -Wextra \
+ -Wno-sign-compare \
"
# These are not compliable yet
More information about the varnish-commit
mailing list