[master] 26776d12f Take two: When writing binary logs, always include Begin/End/Link tags

[Nils Goroll]

On 26/01/2019 10:13, Poul-Henning Kamp wrote:
> Doesn't this change the interpretation of user-provided arguments ?

My mistake with the initial patch was that an initial -i/-I argument clears the
tag mask as "no tags except for the given ones".

With the initial -x argument added,

- if no user arguments were given, the above does not happen due to the initial
  -x argument and and all tags remain included

- if user arguments were given, the -x Link is a noop.

And this change only concerns the -w and not -A case.



For the rest of the discussion, the scenario at hand is

	varnishlog -w file ...
	varnishlog -r file ...

and we should be concerned with the output of the second varnishlog.

The varnishlog -w will now always write Link/Begin/End, which is the right thing
to do, IMHO:

The varnishlog -r needs these tags for -g xvid | request |session, so this
change is a fix.

IIUC, the only side effect is that varnishlog -r file will output the
Link/Begin/End tags if no -iIxX filter is given.

Does anyone see an issue with this? Or am I missing aynthing else?


Nils

-- 

** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

tel +49 40 28805731
mob +49 170 2723133
fax +49 40 42949753

xmpp://slink@jabber.int.uplex.de/

http://uplex.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20190126/40e6c3e1/attachment-0001.bin>