[master] 0582753d3 Add a note regarding a race recently closed

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Fri Mar 8 10:59:06 UTC 2019


commit 0582753d3708bd8cd546b30e6d6096e91a721b39
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Fri Mar 8 11:57:19 2019 +0100

    Add a note regarding a race recently closed
    
    Refs 1dc891a5aad0e20f45726ea1c2d923d520917691
    Refs #2931 #2933

diff --git a/bin/varnishd/http2/cache_http2_proto.c b/bin/varnishd/http2/cache_http2_proto.c
index 99cd7d5d2..acd38868b 100644
--- a/bin/varnishd/http2/cache_http2_proto.c
+++ b/bin/varnishd/http2/cache_http2_proto.c
@@ -644,6 +644,9 @@ h2_rx_headers(struct worker *wrk, struct h2_sess *h2, struct h2_req *r2)
 	if (r2 == NULL) {
 		if (h2->rxf_stream <= h2->highest_stream)
 			return (H2CE_PROTOCOL_ERROR);	// rfc7540,l,1153,1158
+		/* XXX: is it safe to load h2->open_streams without the h2
+		 * session lock held?
+		 */
 		if (h2->open_streams >=
 		    h2->local_settings.max_concurrent_streams) {
 			VSLb(h2->vsl, SLT_Debug,


More information about the varnish-commit mailing list