[master] 1f5526a72 Coverity doesnt know that getaddrinfo only allocates res on success.
Dridi Boukelmoune
dridi at varni.sh
Thu May 9 06:59:23 UTC 2019
On Thu, May 9, 2019 at 8:04 AM Poul-Henning Kamp <phk at freebsd.org> wrote:
>
>
> commit 1f5526a72e63d1d1db4f9a944f8b63ea386d0e6e
> Author: Poul-Henning Kamp <phk at FreeBSD.org>
> Date: Thu May 9 06:03:02 2019 +0000
>
> Coverity doesnt know that getaddrinfo only allocates res on success.
>
> diff --git a/lib/libvarnish/vss.c b/lib/libvarnish/vss.c
> index 38c766203..0ad31a5b9 100644
> --- a/lib/libvarnish/vss.c
> +++ b/lib/libvarnish/vss.c
> @@ -189,7 +189,7 @@ VSS_ResolveOne(void *dst, const char *addr, const char *port,
> retval = VSA_Malloc(res->ai_addr, res->ai_addrlen);
> else
> retval = VSA_Build(dst, res->ai_addr, res->ai_addrlen);
> - freeaddrinfo(res);
> }
> + freeaddrinfo(res);
It fails badly on SunOS, I think we should revert this and mark the
Coverity defect as a false positive instead.
> return (retval);
> }
> _______________________________________________
> varnish-commit mailing list
> varnish-commit at varnish-cache.org
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit
More information about the varnish-commit
mailing list