[6.0] 1898c0012 Coverity doesnt know that getaddrinfo only allocates res on success.

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Wed May 22 09:03:11 UTC 2019


commit 1898c001275aaf08d0b83e75996f5ab3badf744f
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Thu May 9 06:03:02 2019 +0000

    Coverity doesnt know that getaddrinfo only allocates res on success.

diff --git a/lib/libvarnish/vss.c b/lib/libvarnish/vss.c
index 38c766203..0ad31a5b9 100644
--- a/lib/libvarnish/vss.c
+++ b/lib/libvarnish/vss.c
@@ -189,7 +189,7 @@ VSS_ResolveOne(void *dst, const char *addr, const char *port,
 			retval = VSA_Malloc(res->ai_addr, res->ai_addrlen);
 		else
 			retval = VSA_Build(dst, res->ai_addr, res->ai_addrlen);
-		freeaddrinfo(res);
 	}
+	freeaddrinfo(res);
 	return (retval);
 }


More information about the varnish-commit mailing list