[master] 3b4fef08f Sigh, are enums signed or unsigned ? Who knows...

Poul-Henning Kamp phk at FreeBSD.org
Mon Nov 11 10:49:06 UTC 2019


commit 3b4fef08f86a2bad0d8fe9e5dc027cd7680b5dd7
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Mon Nov 11 10:48:00 2019 +0000

    Sigh, are enums signed or unsigned ?  Who knows...

diff --git a/bin/varnishd/cache/cache_session.c b/bin/varnishd/cache/cache_session.c
index afda89314..d536962bf 100644
--- a/bin/varnishd/cache/cache_session.c
+++ b/bin/varnishd/cache/cache_session.c
@@ -160,7 +160,7 @@ SES_Set_String_Attr(struct sess *sp, enum sess_attr a, const char *src)
 	CHECK_OBJ_NOTNULL(sp, SESS_MAGIC);
 	AN(src);
 
-	assert (a >= SA_TRANSPORT && a <  SA_LAST);
+	assert(a <  SA_LAST);
 	if (strcmp(sess_attr[a].type, "char"))
 		WRONG("wrong sess_attr: not char");
 
@@ -175,7 +175,7 @@ SES_Get_String_Attr(const struct sess *sp, enum sess_attr a)
 
 	CHECK_OBJ_NOTNULL(sp, SESS_MAGIC);
 
-	assert (a >= SA_TRANSPORT && a <  SA_LAST);
+	assert(a <  SA_LAST);
 	if (strcmp(sess_attr[a].type, "char"))
 		WRONG("wrong sess_attr: not char");
 


More information about the varnish-commit mailing list