[master] a0a3dfcff use backend None instead of bad_ip backend

Dridi Boukelmoune dridi at varni.sh
Mon Oct 14 12:46:14 UTC 2019


On Wed, Oct 9, 2019 at 11:04 AM Nils Goroll <nils.goroll at uplex.de> wrote:
>
>
> commit a0a3dfcff4390545c02475266a7ae75d9cebc251
> Author: Nils Goroll <nils.goroll at uplex.de>
> Date:   Wed Oct 9 12:52:40 2019 +0200
>
>     use backend None instead of bad_ip backend
>
>     ... for those cases which can easily be changed (most of them).

Otherwise ${bad_backend} would have done the trick too.

>     This avoids issues with failing tests when bad_ip is actually reachable
>     via tcp on the respective port, as seen for example with b00068.vtc

I thought I had taken care of this last time I ran into this problem
but I suppose only a subset of the test cases failed me for this
reason. Should we evaluate the remaining uses of ${bad_ip} and
consider retiring it? Especially since it is purely arbitrary and not
really "bad" per-se.

Dridi


More information about the varnish-commit mailing list