[master] 4fea42575 ws: Comprehensive workspace magic cheese

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Mon Aug 31 18:41:08 UTC 2020


commit 4fea425753f5857b63e02fda4ed8eed90ccdbe27
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Wed Apr 29 11:35:51 2020 +0200

    ws: Comprehensive workspace magic cheese

diff --git a/bin/varnishd/cache/cache_ws.c b/bin/varnishd/cache/cache_ws.c
index 874181436..f3847e5c6 100644
--- a/bin/varnishd/cache/cache_ws.c
+++ b/bin/varnishd/cache/cache_ws.c
@@ -107,7 +107,7 @@ WS_Init(struct ws *ws, const char *id, void *space, unsigned len)
 	ws->e = ws->s + len;
 	*ws->e = 0x15;
 	ws->f = ws->s;
-	assert(id[0] & 0x20);
+	assert(id[0] & 0x20);		// cheesy islower()
 	bstrcpy(ws->id, id);
 	WS_Assert(ws);
 }
@@ -368,7 +368,7 @@ WS_Overflowed(const struct ws *ws)
 	CHECK_OBJ_NOTNULL(ws, WS_MAGIC);
 	AN(ws->id[0]);
 
-	if (ws->id[0] & 0x20)
+	if (ws->id[0] & 0x20)		// cheesy islower()
 		return (0);
 	return (1);
 }


More information about the varnish-commit mailing list