[master] f5dcaeabb Update RedHat / CentOS install instructions for >= 8

[Dridi Boukelmoune]

On Mon, Feb 3, 2020 at 1:15 PM Nils Goroll <nils.goroll at uplex.de> wrote:
>
>
> commit f5dcaeabba2525c5609b66001f4743ba2fbbf7f8
> Author: Nils Goroll <nils.goroll at uplex.de>
> Date:   Mon Feb 3 14:11:00 2020 +0100
>
>     Update RedHat / CentOS install instructions for >= 8
>
>     Basically taken from #3204 by @gquintard
>
>     - sphinx install for release 8
>     - included libunwind though it is optional
>     - left out libconfig libcurl and openssh-clients because
>       varnish-cache does not need them
>
> diff --git a/doc/sphinx/installation/install_source.rst b/doc/sphinx/installation/install_source.rst
> index b9a95cc14..39d30a4cc 100644
> --- a/doc/sphinx/installation/install_source.rst
> +++ b/doc/sphinx/installation/install_source.rst
> @@ -74,16 +74,34 @@ Build dependencies on Red Hat / CentOS
>
>  .. gawk '/^BuildRequires/ {print "* `" $2 "`"}' ../../../redhat/varnish.spec | sort | uniq | egrep -v '(systemd)'
>
> -To build Varnish on a Red Hat or CentOS system, this command should
> -install required packages (replace ``sudo yum install`` if needed)::
> +in the following shell commands, replace ``sudo yum install`` if needed.
>
> -    sudo yum install \
> +Install sphinx
> +
> +* On Red Hat / CentOS 8, sphinx is not included in the default
> +  repositories, so execute these steps to include it from the
> +  PowerTools repository::
> +
> +    sudo dnf install -y 'dnf-command(config-manager)'
> +    sudo yum config-manager --set-enabled PowerTools
> +    sudo yum install -y diffutils python3-sphinx
> +
> +* On Red Hat / CentOS <= 7, install sphinx::
> +
> +    sudo yum install -y python-sphinx

I believe that PowerTools was also needed to install -devel packages,
Guillaume will correct me if I'm wrong.

The reason why this step is done in CircleCI configuration is because
we have multiple `yum install` commands so it would not be convenient
to add --enablerepo to all of them.

> +The following step should conclude installation of the required
> +packages::
> +
> +  yum install -y \

Without the first step from above, a single command should be needed:

    yum -y --enablerepo PowerTools install [pkgs]

>         make \
>         autoconf \
>         automake \
>         jemalloc-devel \
> +       libconfig-devel \
>         libedit-devel \
>         libtool \
> +       libunwind-devel \

We only need libunwind if we enable it at configure time, I would
leave it out of the default list of dependencies.

My 2 cents,
Dridi

>         ncurses-devel \
>         pcre-devel \
>         pkgconfig \
> _______________________________________________
> varnish-commit mailing list
> varnish-commit at varnish-cache.org
> https://www.varnish-cache.org/lists/mailman/listinfo/varnish-commit