[6.2] 841c1e00b Remove extra call to SES_Reserve_proto_priv

Martin Blix Grydeland martin at varnish-software.com
Tue Feb 4 10:03:09 UTC 2020


commit 841c1e00b978a5ecf53f6c72cbd749e1c1730b12
Author: Martin Blix Grydeland <martin at varnish-software.com>
Date:   Thu Dec 12 13:16:40 2019 +0100

    Remove extra call to SES_Reserve_proto_priv
    
    In h2_init_sess, an extra call was always made to SES_Reseve_proto_priv(),
    even though it was already reserved. This wasted a pointer worth of
    session workspace. This patch removes the extra call.

diff --git a/bin/varnishd/http2/cache_http2_session.c b/bin/varnishd/http2/cache_http2_session.c
index 788879bbf..977669589 100644
--- a/bin/varnishd/http2/cache_http2_session.c
+++ b/bin/varnishd/http2/cache_http2_session.c
@@ -130,7 +130,6 @@ h2_init_sess(const struct worker *wrk, struct sess *sp,
 		AZ(VHT_Init(h2->dectbl,
 			h2->local_settings.header_table_size));
 
-		XXXAN(SES_Reserve_proto_priv(sp, &up));
 		*up = (uintptr_t)h2;
 	}
 	AN(up);


More information about the varnish-commit mailing list