[master] b0af060fb simple fix for fedora/gcc-10.0.1: -Werror=format-overflow, by some reason hit on s390x

[Nils Goroll]

>> -                   cmd, i, retval, r);
>> +                   cmd != NULL ? cmd : "NULL", i, retval, r);
> 
> We shouldn't blindly take this change, we should instead ask the GCC
> or Fedora folks (or their intersection) why this is happening. We are
> hiding a potential bug under the rug here.

The gcc error from https://github.com/varnishcache/varnish-cache/issues/3216 is:

inlined from 'varnish_launch' at vtc_varnish.c:500:6:
vtc_varnish.c:121:3: error: '%s' directive argument is null
[-Werror=format-overflow=]

So in my mind the warning is legit, but can only happen with inling.

Can you explain which potential bug you are suspecting?

Nils

-- 

** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

tel +49 40 28805731
mob +49 170 2723133
fax +49 40 42949753

xmpp://slink@jabber.int.uplex.de/

http://uplex.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20200212/adc51c96/attachment.bin>