[master] 4eeec9744 Ensure everything is built before running tests

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Thu Feb 13 21:45:09 UTC 2020


commit 4eeec97447aed237c67070fbf94030edb9967061
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Thu Feb 13 20:26:09 2020 +0100

    Ensure everything is built before running tests
    
    With a growing list of bundled VMODs we want to split the main test
    suite to colocate VMOD-specific tests with the rest of its sources.
    Because a VMOD test case may involve other binaries, and will always
    involve at least varnishtest and varnishd, we insist that make check
    kicks in only after a complete recursive build.
    
    This doesn't work in this scenario:
    
        cd lib/libvmod_<name> && make check
    
    The assumption is that at this point a full build was already performed
    and changes are only happening in that sub directory.
    
    Refs #3184

diff --git a/Makefile.am b/Makefile.am
index c2cbd1c13..60c388610 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -50,6 +50,11 @@ vtest-clean:
 # solved it better, but we don't, so use this at least for now.
 LICENSE: all
 
+# XXX: This is a similar hack to ensure we have a built varnishtest
+# (and technically any other binary that may be involved in a VTC)
+# before we try to run tests anywhere in the tree.
+check-recursive: all
+
 cscope:
 	-rm -f cscope*
 	find . -name '*.[hcS]' > cscope.files


More information about the varnish-commit mailing list