[master] 0f3bb3548 bump default workspace_session

Nils Goroll nils.goroll at uplex.de
Thu Jan 16 10:04:07 UTC 2020


commit 0f3bb35480acadbb910c6f7277d815f40ce5a7f7
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Thu Jan 16 10:47:09 2020 +0100

    bump default workspace_session
    
    02bc0a68379cfb6e856b8b37f074bef0313c3dd4 requires 24 bytes more on
    64bit, which brought o00005.vtc just over the top on smartos 64bit
    machines (the vtc tests PROXY TLVs, which get stored on the session
    workspace).
    
    Increase the default workspace_session by 256bytes (50%) to accomodate
    sane proxy TLV lengths by default.
    
    This is about 10x more than the minimum increase sufficient to
    accomodate the increased workspace usage. I went for 768 bytes because
    
    - this gives us the next least common multiple (12k) with the common 4K
      page size unless we went up to 1k
    
    - we were already quite tight with the default and could not accomodate
      common proxy TLV use (see for example #3131)
    
    As a ballpart reality check, I do not think that spending an additional
    256MB should be an issue for users supporting 1M sessions.

diff --git a/include/tbl/params.h b/include/tbl/params.h
index dd1e68699..ccb416eb0 100644
--- a/include/tbl/params.h
+++ b/include/tbl/params.h
@@ -1731,7 +1731,7 @@ PARAM(
 	/* typ */	bytes_u,
 	/* min */	"0.25k",
 	/* max */	NULL,
-	/* default */	"0.50k",
+	/* default */	"0.75k",
 	/* units */	"bytes",
 	/* flags */	DELAYED_EFFECT,
 	/* s-text */


More information about the varnish-commit mailing list