[master] f47afac0a reduce workspace load on the parameter canary vtc
Nils Goroll
nils.goroll at uplex.de
Mon Jan 27 15:22:07 UTC 2020
commit f47afac0afa606a9872ef50b9b070c0cbb3371e4
Author: Nils Goroll <nils.goroll at uplex.de>
Date: Mon Jan 20 20:17:52 2020 +0100
reduce workspace load on the parameter canary vtc
It now bails out due to a workspace overflow which it acually did
trigger all the time, but that remained unnoticed due to #3194
The test to multiply the cookie header 128 times (8x in the first
regex, 16x in the second) was not realistic even for "modern times",
so I do not think we should have workspaces sized by such an example.
diff --git a/bin/varnishtest/tests/v00004.vtc b/bin/varnishtest/tests/v00004.vtc
index 486f88a50..716f47294 100644
--- a/bin/varnishtest/tests/v00004.vtc
+++ b/bin/varnishtest/tests/v00004.vtc
@@ -153,8 +153,6 @@ varnish v1 -vcl+backend {
sub recv9 {
std.log("STK recv9 " + debug.stk());
set req.http.regex = regsub(req.http.cookie, "(.*)", "\1\1\1\1\1\1\1\1");
- set req.http.regex = regsub(req.http.regex, "(.*)",
- "\1\1\1\1\1\1\1\1\1\1\1\1\1\1\1\1");
# hey geoff, this is deliberate
set req.http.regex = regsub(req.http.regex,
"(.*)(.{5})(.{6})(.{7})(.{8})", "/\5\4\3\2\1");
More information about the varnish-commit
mailing list