[master] 1b04343a0 jail enum assertions

Dridi Boukelmoune dridi at varni.sh
Wed Jun 3 11:31:04 UTC 2020


On Wed, Jun 3, 2020 at 11:12 AM Nils Goroll <nils.goroll at uplex.de> wrote:
>
> On 29/05/2020 18:38, Dridi Boukelmoune wrote:
> > You might as well revert the last two commits and turn the enums into
> > structs right off the bat.
>
> FTR, I have now based code on the assumption that the enums work as array
> indices and would prefer to keep that for simplicity.

The structs could be generated from an include table and have an index field.

> Alternatively, we could have structs with priv pointers to the implementation,
> but at this point I think that the complication would have no relevant benefit.
> Or would it?

I don't think we could make this work with const struct symbols, so
unless there is a compelling reason we should keep the working enums.

Dridi


More information about the varnish-commit mailing list