[master] b90b60d0a shard director: add optional weight parameter to .add_backend()

[Nils Goroll]

Hi Dridi,

thank you for the review :)

> Any reason not to return(fail("reason")) instead of std.log() calls?

The reason is legacy - this was copy-pasta of a long existing test. I'll polish...

>> +       if (args->valid_weight && args->weight > 1)
>> +               weight = args->weight;
>> +
> 
> Shouldn't we VRT_fail() if the supplied weight is not valid?

Yes we should, good point!

Nils

-- 

** * * UPLEX - Nils Goroll Systemoptimierung

Scheffelstraße 32
22301 Hamburg

tel +49 40 28805731
mob +49 170 2723133
fax +49 40 42949753

xmpp://slink@jabber.int.uplex.de/

http://uplex.de/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://www.varnish-cache.org/lists/pipermail/varnish-commit/attachments/20200610/a78ee576/attachment.bin>