[master] 7b2c2be46 fix a comment based on insights from #3434

Nils Goroll nils.goroll at uplex.de
Fri Oct 9 18:06:06 UTC 2020


commit 7b2c2be46f1e6c749fb57e90e362b2fbb3b4d2e7
Author: Nils Goroll <nils.goroll at uplex.de>
Date:   Fri Oct 9 19:50:19 2020 +0200

    fix a comment based on insights from #3434

diff --git a/bin/varnishd/cache/cache_fetch.c b/bin/varnishd/cache/cache_fetch.c
index c8958dfb4..cd975927c 100644
--- a/bin/varnishd/cache/cache_fetch.c
+++ b/bin/varnishd/cache/cache_fetch.c
@@ -1028,9 +1028,7 @@ vbf_fetch_thread(struct worker *wrk, void *priv)
 	VCL_TaskLeave(bo->privs);
 	http_Teardown(bo->bereq);
 	http_Teardown(bo->beresp);
-	// XXX after 6.4 release:
-	// bereq_body should have 0 or 1 references remaining,
-	// see VRB_Free() for the other end
+	// can not make assumptions about the number of references here #3434
 	if (bo->bereq_body != NULL)
 		(void) HSH_DerefObjCore(bo->wrk, &bo->bereq_body, 0);
 


More information about the varnish-commit mailing list