[master] ea8a98070 Backends created on demand must have their probe init to healthy.

Poul-Henning Kamp phk at FreeBSD.org
Mon Apr 19 20:17:10 UTC 2021


commit ea8a9807039752fe9110a1f0c3dea34084c534dc
Author: Poul-Henning Kamp <phk at FreeBSD.org>
Date:   Mon Apr 19 19:17:42 2021 +0000

    Backends created on demand must have their probe init to healthy.
    
    Fixes #3596

diff --git a/bin/varnishtest/tests/d00007.vtc b/bin/varnishtest/tests/d00007.vtc
index 93c0a0c7f..2c05693dc 100644
--- a/bin/varnishtest/tests/d00007.vtc
+++ b/bin/varnishtest/tests/d00007.vtc
@@ -14,7 +14,10 @@ varnish v1 -vcl {
 
 	backend dummy { .host = "${bad_backend}"; }
 
-	probe pr {}
+	probe pr {
+		.threshold = 8;
+		.initial = 8;
+	}
 
 	sub vcl_init {
 		new s1 = debug.dyn("0.0.0.0", "0");
diff --git a/doc/sphinx/reference/vcl-probe.rst b/doc/sphinx/reference/vcl-probe.rst
index 569c83566..6d05e48ae 100644
--- a/doc/sphinx/reference/vcl-probe.rst
+++ b/doc/sphinx/reference/vcl-probe.rst
@@ -160,6 +160,11 @@ The default values are:
 
 * ``.initial`` = one less than ``.threshold``
 
+Note that the default ``.initial`` means that the backend will be marked
+unhealthy until the first probe response come back successful.
+This means that for backends created on demand (by vmods) cannot use the
+default value for ``.initial``, as the freshly created backend would very
+likely still be unhealthy when the backend request happens.
 
 SEE ALSO
 ========


More information about the varnish-commit mailing list