[master] 739c54da7 Adjust the minimum value of h2_initial_window_size

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Mon Aug 30 08:31:08 UTC 2021


commit 739c54da7e9abb1a8a00b02189e46ca66ba25459
Author: Martin Blix Grydeland <martin at varnish-software.com>
Date:   Tue Jun 22 11:49:31 2021 +0200

    Adjust the minimum value of h2_initial_window_size
    
    We have a strict min at the protocol default here. This is because we
    don't have the 'use settings only after peer ack' in place yet. If the
    value is lower than the protocol default, the very first stream could get
    a flow control error.

diff --git a/include/tbl/params.h b/include/tbl/params.h
index 7d383b8d2..ccd5a8f54 100644
--- a/include/tbl/params.h
+++ b/include/tbl/params.h
@@ -1195,15 +1195,19 @@ PARAM_SIMPLE(
 	"at the same time for a single HTTP2 connection."
 )
 
+/* We have a strict min at the protocol default here. This is because we
+ * don't have the 'use settings only after peer ack' in place yet. If the
+ * value is lower than the protocol default, the very first stream could
+ * get a flow control error. */
 PARAM_SIMPLE(
 	/* name */	h2_initial_window_size,
 	/* type */	bytes_u,
-	/* min */	"0",
+	/* min */	"65535b",
 	/* max */	"2147483647b",
 	/* def */	"65535b",
 	/* units */	"bytes",
 	/* descr */
-	"HTTP2 initial flow control window size."
+	"HTTP2 initial flow control window size.",
 )
 
 PARAM_SIMPLE(


More information about the varnish-commit mailing list