[master] f9a802fa2 Revert "param: Plug leak spotted by lsan"

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Tue Dec 14 16:20:07 UTC 2021


commit f9a802fa26e143175bcf253212c3284299e83d4d
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Tue Dec 14 17:17:24 2021 +0100

    Revert "param: Plug leak spotted by lsan"
    
    This reverts commit 82be6f46a73a99bff56e51140e138c569f34ff36.

diff --git a/bin/varnishd/mgt/mgt_param.c b/bin/varnishd/mgt/mgt_param.c
index d023b6e72..4070ddb42 100644
--- a/bin/varnishd/mgt/mgt_param.c
+++ b/bin/varnishd/mgt/mgt_param.c
@@ -264,7 +264,6 @@ mcf_param_show(struct cli *cli, const char * const *av, void *priv)
 		if (show != NULL) {
 			VCLI_SetResult(cli, CLIS_TOOMANY);
 			VCLI_Out(cli, "Too many parameters");
-			VSB_destroy(&vsb);
 			return;
 		}
 		show = av[n];
@@ -389,7 +388,6 @@ mcf_param_show_json(struct cli *cli, const char * const *av, void *priv)
 		if (show != NULL) {
 			VCLI_SetResult(cli, CLIS_TOOMANY);
 			VCLI_Out(cli, "Too many parameters");
-			VSB_destroy(&vsb);
 			return;
 		}
 		show = av[i];


More information about the varnish-commit mailing list