[master] cea4eb2d0 vsl: Plug leak when initial reset fails

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Mon Jan 18 16:06:07 UTC 2021


commit cea4eb2d0452acf6f946d8a5b02d7e77ce4c6df0
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Tue Nov 17 10:32:18 2020 +0100

    vsl: Plug leak when initial reset fails

diff --git a/lib/libvarnishapi/vsl_cursor.c b/lib/libvarnishapi/vsl_cursor.c
index 687d618e0..6b1284667 100644
--- a/lib/libvarnishapi/vsl_cursor.c
+++ b/lib/libvarnishapi/vsl_cursor.c
@@ -295,6 +295,7 @@ VSL_CursorVSM(struct VSL_data *vsl, struct vsm *vsm, unsigned options)
 
 	r = vslc_vsm_reset(&c->cursor);
 	if (r != vsl_end) {
+		AZ(VSM_Unmap(vsm, &vf));
 		(void)vsl_diag(vsl, "Cursor initialization failure (%d)", r);
 		FREE_OBJ(c);
 		return (NULL);


More information about the varnish-commit mailing list