[master] 903ea6039 Revert "vcc: Add missing ERRCHK to vcc_expr5()"

Dridi Boukelmoune dridi.boukelmoune at gmail.com
Thu Jun 3 06:28:06 UTC 2021

commit 903ea60399cf4480e8d1550323bab6bbada67d51
Author: Dridi Boukelmoune <dridi.boukelmoune at gmail.com>
Date:   Thu Jun 3 08:19:57 2021 +0200

    Revert "vcc: Add missing ERRCHK to vcc_expr5()"
    This reverts commit 2bc56a4b789fb770548aa6d528c8c8d6d296d4a1.
    We already assert that sym is not null, and we certainly don't expect a
    reserved symbol to have slipped through since we already attempted the
    least specific symnbol lookup.
    This is not a case where we expect to fail because of user input.

diff --git a/lib/libvcc/vcc_expr.c b/lib/libvcc/vcc_expr.c
index b41395aff..55d311ea8 100644
--- a/lib/libvcc/vcc_expr.c
+++ b/lib/libvcc/vcc_expr.c
@@ -745,7 +745,6 @@ vcc_expr5(struct vcc *tl, struct expr **e, vcc_type_t fmt)
 		if (sym == NULL && fmt->global_pfx != NULL && t1->tok != '.') {
 			sym = VCC_SymbolGet(tl, SYM_MAIN, SYM_NONE,
-			ERRCHK(tl);
 			VCC_GlobalSymbol(sym, fmt);

More information about the varnish-commit mailing list