[6.0] 204c5b73e Increase default stack space

PÃ¥l Hermunn Johansen hermunn at varnish-software.com
Tue Nov 9 15:49:05 UTC 2021


commit 204c5b73e3ecb6b9b1533bad437dc9086c0269aa
Author: Pål Hermunn Johansen <hermunn at varnish-software.com>
Date:   Thu May 20 14:10:15 2021 +0200

    Increase default stack space
    
    A default stack space of 48k will cause a stack overflow in some of
    the test cases on some Linux distributions. The increase to 64k seems
    to be enough to solve this.

diff --git a/bin/varnishd/mgt/mgt_param.c b/bin/varnishd/mgt/mgt_param.c
index c87c891a6..0b0408776 100644
--- a/bin/varnishd/mgt/mgt_param.c
+++ b/bin/varnishd/mgt/mgt_param.c
@@ -646,9 +646,9 @@ MCF_InitParams(struct cli *cli)
 	MCF_ParamConf(MCF_MINIMUM, "thread_pool_stack", "%jdb", (intmax_t)low);
 
 #if defined(__SANITIZER) || __has_feature(address_sanitizer)
-	def = 92 * 1024;
+	def = 128 * 1024;
 #else
-	def = 48 * 1024;
+	def = 64 * 1024;
 #endif
 	if (def < low)
 		def = low;
diff --git a/doc/changes.rst b/doc/changes.rst
index de40d44ff..fa6cf41c9 100644
--- a/doc/changes.rst
+++ b/doc/changes.rst
@@ -26,6 +26,14 @@ http://varnish-cache.org/docs/trunk/whats-new/index.html and via
 individual releases. These documents are updated as part of the
 release process.
 
+================================
+Varnish Cache 6.0.9 (unreleased)
+================================
+
+* Increase the default stack size to 64k. (3617_)
+
+.. _3617: https://github.com/varnishcache/varnish-cache/pull/3617
+
 ================================
 Varnish Cache 6.0.8 (2021-07-13)
 ================================
diff --git a/include/tbl/params.h b/include/tbl/params.h
index deecd2051..5fe1e2dd6 100644
--- a/include/tbl/params.h
+++ b/include/tbl/params.h
@@ -1329,7 +1329,7 @@ PARAM(
 	/* typ */	bytes,
 	/* min */	"2k",
 	/* max */	NULL,
-	/* default */	"48k",
+	/* default */	"64k",
 	/* units */	"bytes",
 	/* flags */	EXPERIMENTAL,
 	/* s-text */


More information about the varnish-commit mailing list